Skip to content

[PLT-0] Fix Integration Tests #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2024
Merged

[PLT-0] Fix Integration Tests #1699

merged 3 commits into from
Jun 28, 2024

Conversation

adrian-chang
Copy link
Contributor

Description

  • Add timestamps

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@adrian-chang adrian-chang requested a review from a team as a code owner June 27, 2024 03:22
@adrian-chang adrian-chang force-pushed the achang/plt-0-int-tests- branch from 20fa9a1 to 19df06a Compare June 27, 2024 08:30
@adrian-chang adrian-chang force-pushed the achang/plt-0-int-tests- branch 3 times, most recently from 1d529c4 to 91be53a Compare June 28, 2024 06:12
vbrodsky
vbrodsky reviewed Jun 28, 2024
View reviewed changes
libs/labelbox/tests/data/annotation_import/test_bulk_import_request.py
@@ -25,7 +25,7 @@

"""


@pytest.mark.order(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and why is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is very slow, this guarantees it runs first (given all tests that you may be running) to prioritize it to optimize testing time

@adrian-chang adrian-chang force-pushed the achang/plt-0-int-tests- branch from 74b2d2a to 6fcae4d Compare June 28, 2024 17:09
@adrian-chang adrian-chang force-pushed the achang/plt-0-int-tests- branch from 515f2ab to 839035a Compare June 28, 2024 17:26
@adrian-chang adrian-chang force-pushed the achang/plt-0-int-tests- branch from 839035a to 7815ca0 Compare June 28, 2024 17:59
adrian-chang
adrian-chang commented Jun 28, 2024
View reviewed changes
libs/labelbox/tests/data/annotation_import/test_data_types.py
@@ -259,7 +198,7 @@ def validate_iso_format(date_string: str):
assert parsed_t.minute is not None
assert parsed_t.second is not None


@pytest.mark.order(1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are to note to run first because they are slower

martin-palermo
martin-palermo approved these changes Jun 28, 2024
View reviewed changes
Copy link

@martin-palermo martin-palermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrian-chang adrian-chang merged commit d142f7b into develop Jun 28, 2024
2 of 4 checks passed
@adrian-chang adrian-chang deleted the achang/plt-0-int-tests- branch June 28, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrodsky vbrodsky vbrodsky approved these changes

@martin-palermo martin-palermo martin-palermo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-chang @vbrodsky @martin-palermo